WIP - add Symfony Uid Support#199
Open
jrushlow wants to merge 5 commits into
Open
Conversation
Contributor
|
Maybe you can add a test for ULID because I had to change the Code dosn't work for me without |
|
Hello, any update on this? |
Contributor
|
You just assume that id will be the identifier field name and this is bad. then just |
|
I don't think we will have some updates on this particular PR, so I'd suggest if someone have ideas how to implement this feature then you are welcome to create another PR and go through review process. May the force be with you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #198