Skip to content

fix: add npm cache config and package-lock.json verification to desktop CI workflows #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SynTechRev merged 2 commits into from
Apr 12, 2026
Merged

fix: add npm cache config and package-lock.json verification to desktop CI workflows #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d1285d
Initial plan
Copilot Apr 12, 2026
dbe3920
fix: add npm cache config and package-lock.json verification to deskt…
Copilot Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/desktop-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
cache-dependency-path: 'desktop/package-lock.json'

- name: Verify package-lock.json exists
working-directory: desktop
shell: bash
run: |
if [ ! -f package-lock.json ]; then
echo "Error: desktop/package-lock.json not found" >&2
exit 1
fi
echo "package-lock.json found"

- name: Install desktop dependencies
working-directory: desktop
Expand Down Expand Up @@ -68,6 +80,8 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20
cache: 'npm'
cache-dependency-path: 'desktop/package-lock.json'
Comment on lines +83 to +84
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow still runs npm ci in frontend/, but the repo does not contain frontend/package-lock.json. npm ci will fail in that directory regardless of the new desktop lock verification/caching. To fix the build, either commit a lockfile for frontend/ (preferred for reproducible installs) and update caching accordingly, or switch the frontend install step(s) to npm install.

Copilot uses AI. Check for mistakes.

- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -104,6 +118,16 @@ jobs:
echo "Error: frontend/out not found. Ensure ELECTRON_BUILD=1 was set." >&2
exit 1
fi
- name: Verify package-lock.json exists
working-directory: desktop
shell: bash
run: |
if [ ! -f package-lock.json ]; then
echo "Error: desktop/package-lock.json not found" >&2
exit 1
fi
echo "package-lock.json found"

- name: Install desktop dependencies
working-directory: desktop
run: npm ci
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/release-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ jobs:
pip install -e ".[dev]"
pip install pyinstaller

- name: Verify package-lock.json exists
working-directory: desktop
shell: bash
run: |
if [ ! -f package-lock.json ]; then
echo "Error: desktop/package-lock.json not found" >&2
exit 1
fi
echo "package-lock.json found"
Comment on lines +60 to +68
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow runs npm ci under frontend/, but there is no frontend/package-lock.json in the repository. This will still fail even with the added desktop lock verification. Consider adding a frontend lockfile (and caching it) or changing the frontend install to npm install.

Copilot uses AI. Check for mistakes.

- name: Build Python backend
working-directory: desktop
run: |
Expand Down
Loading