docs: add architecture deep dive#111
Merged
AmitoVrito merged 1 commit intoMay 30, 2026
Merged
Conversation
Contributor
Author
|
@AmitoVrito , looks like the test fail is from your side. Do check |
Contributor
|
@DhruvGarg111 ,that's the welcome workflow failing, not a docs build or test failure your changes are fine. It's a permissions issue in the CI config on our side, nothing to do with your PR. I will look into it and merge separately |
AmitoVrito
approved these changes
May 30, 2026
Contributor
AmitoVrito
left a comment
There was a problem hiding this comment.
Good write-up, Dhruv. The reading map at the top is a nice touch — makes it easy to jump to the section you actually need rather than reading the whole thing. The CI failure was a bug in the welcome workflow on our end, not your changes. Fixed and pushed to main. Merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Closes #673