fix(install): an explicit package set narrows the baseline on a bound portal too

src/MeshWeaver.PluginCatalog/InstanceAutoRegistrationService.cs

@@ -844,8 +844,8 @@ private IObservable<DefaultInstallSummary> InstallDefaults(PluginCatalogOptions
                 + "Source/* pattern and match nothing: [{Malformed}]. The list is therefore not an explicit "
                 + "package set, and the preInstalled baseline is kept.",
                 malformed.Count, string.Join(", ", malformed));
-        var baseline = BaselineApplies(options.InstallPreInstalledPackagesConfigured, options.InstallByDefault);
-        if (options.InstallPreInstalledPackagesConfigured is null && !baseline)
+        var baseline = BaselineApplies(options.EffectiveInstallPreInstalledPackages, options.InstallByDefault);
+        if (options.EffectiveInstallPreInstalledPackages is null && !baseline)
             logger.LogInformation(
                 "[DefaultInstall] PluginCatalog:InstallByDefault declares an EXPLICIT package set [{Wanted}] — "
                 + "exactly those packages and what they declare in `requires` are selected; the "

src/MeshWeaver.PluginCatalog/PluginCatalogOptions.cs

@@ -152,27 +152,47 @@ public sealed class PluginCatalogOptions
     /// declares an EXPLICIT set — every entry naming a package (<c>Source/Package</c>), none a whole
     /// source (<c>Source/*</c>). A deployment that names its packages gets exactly those plus their
     /// declared <c>requires</c>; until this, the baseline added every <c>preInstalled</c> package of
-    /// every source on top (a fresh control instance naming five packages selected 48). Set it
-    /// <c>true</c> to keep the baseline beside a declared set, <c>false</c> to suppress it
-    /// everywhere — an explicit value always wins. The getter keeps reading <c>true</c> while
-    /// unset (the surface and its default are unchanged); the decision reads
-    /// <see cref="InstallPreInstalledPackagesConfigured"/>, which tells "unset" from "true".</para>
+    /// every source on top (a fresh control instance naming five packages selected 48). Configure the
+    /// key <c>true</c> to keep the baseline beside a declared set, <c>false</c> to suppress it
+    /// everywhere — an explicit configured value always wins. 🚨 In CODE, assigning this property
+    /// <c>true</c> is indistinguishable from its default (the configuration binder writes the
+    /// default back through the setter on every bind, so "set to true" cannot be told from "not
+    /// set"); code that wants the baseline beside an explicit set assigns
+    /// <see cref="InstallPreInstalledPackagesConfigured"/> = <c>true</c>. Assigning <c>false</c>
+    /// here still suppresses it. This property keeps its surface and default
+    /// (<c>true</c>); "unset" is read from <see cref="InstallPreInstalledPackagesConfigured"/>, which
+    /// the configuration binds from the SAME key.</para>
     /// </summary>
-    public bool InstallPreInstalledPackages
-    {
-        get => installPreInstalledPackages ?? true;
-        set => installPreInstalledPackages = value;
-    }
+    public bool InstallPreInstalledPackages { get; set; } = true;
 
-    private bool? installPreInstalledPackages;
+    /// <summary>
+    /// <c>PluginCatalog:InstallPreInstalledPackages</c> exactly as CONFIGURED — null when the key is
+    /// absent. Bound from the same key as <see cref="InstallPreInstalledPackages"/>
+    /// (<see cref="Microsoft.Extensions.Configuration.ConfigurationKeyNameAttribute"/>).
+    ///
+    /// <para>🚨 <b>Why a second, nullable property and not a nullable backing field behind the
+    /// bool.</b> <c>ConfigurationBinder</c> reads every bindable property's CURRENT value and writes
+    /// it back through the setter whether or not the key exists (it skips only a null value). A bool
+    /// whose getter answered <c>true</c> while unset was therefore always "set to true" by binding,
+    /// and the explicit-set rule never fired on a deployed portal — measured on a fresh control
+    /// instance running the first fix: the pass still selected 48 packages. A <c>bool?</c> that is
+    /// null is left alone by the binder, so null here really means "not configured".</para>
+    ///
+    /// <para>Code that builds the options by hand may set either: an explicit <c>false</c> on
+    /// <see cref="InstallPreInstalledPackages"/> still suppresses the baseline; to keep the baseline
+    /// beside an explicit set in code, set this property to <c>true</c>.</para>
+    /// </summary>
+    [Microsoft.Extensions.Configuration.ConfigurationKeyName(nameof(InstallPreInstalledPackages))]
+    public bool? InstallPreInstalledPackagesConfigured { get; set; }
 
     /// <summary>
-    /// <see cref="InstallPreInstalledPackages"/> as CONFIGURED: null when nothing set it (no
-    /// configuration key, no assignment), else the value set. What the default install's baseline
-    /// decision reads — an explicit value wins, an unset one follows
-    /// <see cref="InstallByDefault"/>.
+    /// The baseline decision's input: <see cref="InstallPreInstalledPackagesConfigured"/> when the
+    /// configuration states it, else <c>false</c> when code set
+    /// <see cref="InstallPreInstalledPackages"/> to false, else null (unset — follow
+    /// <see cref="InstallByDefault"/>).
     /// </summary>
-    public bool? InstallPreInstalledPackagesConfigured => installPreInstalledPackages;
+    public bool? EffectiveInstallPreInstalledPackages =>
+        InstallPreInstalledPackagesConfigured ?? (InstallPreInstalledPackages ? null : false);
     /// <summary>This installation's public base URL, recorded on the instance node (advisory).
     /// 🚨 Since #3650 it is also where a registry DELIVERS its module-published broadcast
     /// (<see cref="ModulePublished"/>): an installation that records none is reached by the safety

test/Memex.Portal.Shared.Test/StoreBootstrapLandsModulesFirstTest.cs

@@ -19,6 +19,7 @@
 using MeshWeaver.Mesh.Services;
 using MeshWeaver.Plugin.Packaging;
 using MeshWeaver.PluginCatalog;
+using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 using PackagingManifest = MeshWeaver.Plugin.Packaging.PluginManifest;
@@ -529,6 +530,46 @@ public void NoPatterns_OrAWholeSource_KeepsTheBaseline()
         InstanceAutoRegistrationService.BaselineApplies(false, Parse()).Should().BeFalse();
     }
 
+    /// <summary>
+    /// 🚨 The decision as a DEPLOYED portal reaches it: options BOUND from configuration, the way
+    /// <c>MemexConfiguration</c> builds them. The first fix read a nullable backing field behind the
+    /// bool; <c>ConfigurationBinder</c> writes every property's current value back through its setter,
+    /// so the field was always "true" and a fresh control instance naming five packages still selected
+    /// 48. Unset must stay unset through binding.
+    /// </summary>
+    [Theory]
+    [InlineData(null, false)]
+    [InlineData("true", true)]
+    [InlineData("false", false)]
+    public void BoundFromConfiguration_AnExplicitSet_FollowsTheKeyOnly(string? key, bool expectedBaseline)
+    {
+        var entries = new Dictionary<string, string?>
+        {
+            ["PluginCatalog:InstallByDefault:0"] = "Plugins/EntityViews",
+            ["PluginCatalog:InstallByDefault:1"] = "Plugins/Chat",
+        };
+        if (key is not null)
+            entries["PluginCatalog:InstallPreInstalledPackages"] = key;
+        var options = new Microsoft.Extensions.Configuration.ConfigurationBuilder()
+            .AddInMemoryCollection(entries).Build()
+            .GetSection(PluginCatalogOptions.SectionName).Get<PluginCatalogOptions>()!;
+
+        InstanceAutoRegistrationService.BaselineApplies(options.EffectiveInstallPreInstalledPackages, options.InstallByDefault)
+            .Should().Be(expectedBaseline);
+    }
+
+    [Fact]
+    public void BoundFromConfiguration_NoPatterns_KeepsTheBaseline()
+    {
+        var options = new Microsoft.Extensions.Configuration.ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?> { ["PluginCatalog:HomeUrl"] = "https://x.example" })
+            .Build().GetSection(PluginCatalogOptions.SectionName).Get<PluginCatalogOptions>()!;
+        InstanceAutoRegistrationService.BaselineApplies(options.EffectiveInstallPreInstalledPackages, options.InstallByDefault)
+            .Should().BeTrue();
+        new PluginCatalogOptions { InstallPreInstalledPackages = false }.EffectiveInstallPreInstalledPackages
+            .Should().Be(false, "code that sets the bool to false still suppresses");
+    }
+
     [Fact]
     public void AMalformedEntry_IsNotAnExplicitSet_SoTheBaselineStays()
     {