MCP get: the /area/ route keeps an id that contains ':' (#6815)

[rbuergi]

Closes #6815

Root cause

MeshOperations.TryParseAreaRoute returned false for ANY path containing ':', to leave the legacy {path}/area:Name form to the unified resolver. A reference id is free text (url=https://github.com/x), so get {node}/area/{Name}/{Id} with such an id fell through to TryResolveUnifiedPath, which split at the colon and answered No node found at '{node}/area/{Name}'.

Fix

The /area/ route now wins whenever its area segment lies wholly before the first colon; everything after {Name}/ is the id, verbatim. A colon at or before the marker ({path}/area:Name, area:content:file, {path}/data:…) is still the legacy form and keeps flowing through the unified resolver unchanged.

The portal URL route is a different code path (it does not go through TryParseAreaRoute); not changed here.

Tests

test/Memex.Portal.Shared.Test/AreaRouteIdWithColonTest.cs — parse-level (colon id keeps the route; four legacy colon shapes are left to the unified resolver) and end-to-end MeshOperations.Get: the colon id renders ECHO[url=https://github.com/Systemorph/MeshWeaver], and the legacy @node/area:Echo/legacy-id still resolves. 7/7 pass; UngrantedGetIsNotFoundTest 5/5.

Negative control (old early return restored): 2 fail, quoting the issue's exact symptom —
Expected "Error: No node found at 'AreaRouteColonProbe/area/Echo'. Closest ancestor is 'AreaRouteColonProbe' (remainder='area/Echo')…" to contain "ECHO[url=https://github.com/Systemorph/MeshWeaver]".

Release -warnaserror: MeshWeaver.Mesh.Operations and Memex.Portal.Shared.Test, 0 warnings / 0 errors.

Doc: Doc/AI/Tools/MeshPlugin → Get → "Layout areas".

Pairs-with: none — TryParseAreaRoute was private and is now internal; no public surface removed.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Legacy colon references are misrouted when their node path contains an interior area segment.

1 open finding

• Preserve legacy resolution with interior area path segments · New

What changed in this PR

Updates MCP Get routing to support layout-area ids containing colons, addressing #6815.

Changes:

• Recognizes /area/ markers before the first colon.
• Adds parser and end-to-end regression tests.
• Documents layout-area routes and reference ids.

File	Description
test/​Memex.Portal.Shared.Test/​AreaRouteIdWithColonTest.cs	Tests colon-containing ids and legacy references.
src/​MeshWeaver.Mesh.Operations/​MeshOperations.cs	Adjusts area-route parsing and exposes it internally for tests.
src/​MeshWeaver.Documentation/​Data/​AI/​Tools/​MeshPlugin.md	Documents area reads and colon handling.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Test Results

   11 files   -    15     11 suites   - 15   38m 58s ⏱️ - 20m 59s
9 158 tests  - 3 567  9 158 ✅  - 3 374  0 💤  - 193  0 ❌ ±0 
9 173 runs   - 3 568  9 173 ✅  - 3 375  0 💤  - 193  0 ❌ ±0 

Results for commit 71b5a98. ± Comparison against base commit cab0ae9.

This pull request removes 3614 and adds 21 tests. Note that renamed tests count towards both.

   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---)
   --- End of inner exception stack trace ---, expected: True)
   --- End of inner exception stack trace ---, isDenial: True)
 ---> (Inner Exception #1) MeshWeaver.Mesh.QueryProviderStalledException: Query provider(s) [pg] did not emit an Initial within the query fan-in's 16s bound for query 'nodeType:NodeType' (user 'system'). The merged Initial gates on EVERY provider, so this query has NO snapshot to answer with — it is reported as unavailable (retryable) rather than left hanging with no error. This is an availability failure, never a permission verdict: a consumer deciding access must fail CLOSED and say it could not establish the answer. Fix the stalled provider; never bump the consumer's timeout.<---
 ---> (Inner Exception #1) MeshWeaver.Messaging.Hub.Test.InfrastructureFaultTest+ProviderException (0x80004005): Failed to connect to 10.42.18.4:5432<---
 ---> (Inner Exception #1) System.ArgumentException: Value does not fall within the expected range.<---
 ---> (Inner Exception #1) System.InvalidOperationException: boom<---
 ---> (Inner Exception #1) System.InvalidOperationException: source B is misconfigured<---
…

Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Get_AreaRoute_WithColonInId_RendersThatId
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Get_LegacyColonForm_StillResolves
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_IdWithColon_KeepsTheAreaRoute
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_InteriorAreaSegment_WithColonId_SplitsAtTheDeepestMarker
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "AreaRouteColonProbe/area:Echo")
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "AreaRouteColonProbe/area:Echo/legacy-id")
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "AreaRouteColonProbe/area:content:logo.svg")
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "AreaRouteColonProbe/data:Collection/area/x")
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "Root/area/Child/area:Echo")
Memex.Portal.Shared.Test.AreaRouteIdWithColonTest ‑ Parse_LegacyColonForm_IsLeftToTheUnifiedResolver(path: "Root/area/Child/area:Echo/legacy-id")
…

♻️ This comment has been updated with latest results.

[Copilot]

🔵 Needs a closer look

Legacy-route compatibility needs human confirmation before approval.

0 open findings

1 resolved since last review

• Preserve legacy resolution with interior area path segments

🧠 Review effort: Balanced