Repository navigation
Untyped select: reads are projected after the merged sort #6839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in 6bda942. The provider ranked free-text matches by fuzzy score before its load cap, but it left
Scoresnull, soClipMergedInitialscored every row 0 and returned path order. That was already true for TYPED free-text reads, and routing untypedselect:reads through the node merge extended it to them. The root fix is inStorageAdapterMeshQueryProvider.RunRankedQueryNodestakes the score off the matched node before any projection or content drop and carries it on the Initial frame, aligned with the rows that pass the type filter. Live deltas are unchanged.Regressions in
UntypedProjectionMergedSortTestuse a fixture where relevance order is the reverse of path order. The expected order comes fromQueryEvaluator.GetFuzzyScoreitself, with a guard that it disagrees with path order.IMeshQueryCore.Query), typed and untyped, with and withoutselect:.Skip=1 Limit=1pages the relevance order.MeshQuery.Query<T>(request)) needs a hub for its serializer options. It is pinned at the frame it merges: the securedIMeshQueryProvider.Query<T>Initial carries one descending score per row, the same for typed and untyped reads.Negative control: with
Scores = nullrestored, 5 of the 10 cases fail (for example, expectedneedle, the needle somewhere, …but got the path ordera long haystack…, the needle somewhere, needle). With the fix all 10 pass, and so do the adjacent query suites (PagedQueryTotalOrder, MeshQueryMergeContract, ContentFieldSort, FilterOnlyQueryClipsNewestFirst).