Merged
Conversation
adds generated files from mingw windows build, gperf files, and artifacts from patch (*.orig, *.rej).
rogerman
reviewed
Jan 21, 2026
Collaborator
rogerman
left a comment
rogerman
left a comment
There was a problem hiding this comment.
You actually don't need to explicitly enable gamehacks.en by default, because the core code already does this:
desmume/desmume/src/NDSSystem.cpp
Line 3386 in f96a6d6
Collaborator
Author
|
rogerman: good find. i removed the offending commit. |
this game has a bug that's exposed when minimal timing differences exist. credits: @taxicat1 closes TASEmulators#29
Collaborator
|
Tested all three games, and they seem to work just fine with this game hack. Here's a screenshot of the European version of My Puppy Shop (NTR-YPTP-EUR): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.