Conversation
BitaEt
reviewed
Oct 15, 2022
Collaborator
BitaEt
left a comment
BitaEt
left a comment
There was a problem hiding this comment.
I again forgot to push the button and my reviews were pending
| extracted_cont = titanic_df[col] | ||
| cont_df = cont_df.append(extracted_cont) | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
where does your histogram data come from? (x label), it doesn't have any input now
BitaEt
reviewed
Oct 15, 2022
| X = titanic_df.data | ||
| y = titanic_df.target | ||
|
|
||
| for idx, column in enumerate(X.T): |
Collaborator
There was a problem hiding this comment.
We're not working with the diabetes dataset
BitaEt
reviewed
Oct 15, 2022
bda602_hw4.py
Outdated
| ) | ||
| fig_1.show() | ||
| fig_1.write_html( | ||
| file="../../../plots/lecture_6_cont_response_cat_predictor_dist_plot.html", |
Collaborator
There was a problem hiding this comment.
I think you should remove all these file variables in functions.
unless I have a revelation.
BitaEt
reviewed
Oct 15, 2022
bda602_hw4.py
Outdated
|
|
||
| cat_df = [] | ||
| cont_df = [] | ||
| for col in titanic_df: |
Collaborator
There was a problem hiding this comment.
For titanic we have numeric "categorical" variables. Like pclass, this code fails to recognize them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.