Skip to content

[REFACTOR/#222] 예지 2차 QA - #230

Merged
apffkxhsls merged 2 commits into
developfrom
refactor/#222-yeji_qa_2
Jul 17, 2026
Merged

apffkxhsls merged 2 commits into
developfrom
refactor/#222-yeji_qa_2

Conversation

@apffkxhsls

@apffkxhsls apffkxhsls commented Jul 17, 2026 •

Copy link
Copy Markdown
Collaborator

Related issue 🛠

Work Description ✏️

  • 디자인 QA

Screenshot 📸

Uncompleted Tasks 😅

  • 배경색 관련 오류 수정

To Reviewers 📢

image

Summary by CodeRabbit

  • 버그 수정
    • 수업 상세 화면의 콘텐츠 영역 크기 배분과 스크롤 동작을 개선했습니다.
    • 진행 중, 완료, 취소 및 사전 수업 화면에서 다양한 콘텐츠 길이에도 레이아웃이 안정적으로 표시됩니다.

@apffkxhsls apffkxhsls added ♻️ REFACTOR 전면 수정, 리팩토링 💛 예지 labels Jul 17, 2026
@apffkxhsls apffkxhsls added this to the [Ssing] APPJAM milestone Jul 17, 2026
@apffkxhsls apffkxhsls self-assigned this Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

강사 레슨 상세 화면 4곳의 Column Modifier 구성이 조정되었습니다. 스크롤 영역에서는 weight와 verticalScroll 순서가 변경되었고, 일부 콘텐츠 영역에서는 fillMaxWidth가 weight로 교체되었습니다.

Changes

Lesson detail layout

Layer / File(s) Summary
Column Modifier 및 공간 배분 조정
presentation/instructor-lesson/.../screen/LessonDetail*Screen.kt
스크롤 가능한 Column에서 weight(1f)가 verticalScroll보다 먼저 적용되도록 변경하고, 일부 내부 Column의 fillMaxWidth()를 weight(1f)로 교체했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: 📱UI

Suggested reviewers: joyrii, doorimng

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed #222의 디자인 QA 요구에 맞게 레이아웃 조정만 반영되어 있어 링크된 이슈의 범위를 충족합니다.
Out of Scope Changes check ✅ Passed 추가된 변경은 모두 인스트럭터 레슨 화면의 Modifier 조정으로 보이며, 명백한 범위 외 변경은 없습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed 이 제목은 이슈 #222의 2차 QA를 가리켜 변경 내용과 관련은 있으나, 핵심 수정 내용을 더 구체적으로 드러내진 않습니다.
Description check ✅ Passed 필수 섹션(Related issue, Work Description, Screenshot, Uncompleted Tasks, To Reviewers)을 대부분 갖춰 템플릿을 충족합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#222-yeji_qa_2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@apffkxhsls
apffkxhsls requested a review from a team July 17, 2026 11:13

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailBeforeScreen.kt`:
- Around line 105-107: Remove the ineffective weight(1f) modifier from the
background Column inside the verticalScroll content in
LessonDetailBeforeScreen.kt (105-107), LessonDetailCompletedScreen.kt (69-71),
and LessonDetailOngoingScreen.kt (69-71); use the appropriate fillMaxWidth() or
fillMaxSize() modifier, or move the background outside the scroll container, so
it expands as intended.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dfae9c04-afa5-4c65-a7eb-9aebe258afc4

📥 Commits

Reviewing files that changed from the base of the PR and between 03a245e and 217531c.

📒 Files selected for processing (4)
  • presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailBeforeScreen.kt
  • presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailCanceledScreen.kt
  • presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailCompletedScreen.kt
  • presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailOngoingScreen.kt

@apffkxhsls
apffkxhsls merged commit b184457 into develop Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ REFACTOR 전면 수정, 리팩토링 💛 예지

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] 예지 2차 QA

1 participant