[REFACTOR/#229] 도연 3차 QA - #234
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough매칭 요청 요약에 요청자와 참여자 상세 정보가 추가되어 결제 화면에 표시됩니다. 소비자·강사 홈 카드의 상태 및 칩 매핑이 변경되었고, 리뷰 카드의 여백 배치가 조정되었습니다. Changes매칭 참여자 데이터 흐름
강습 카드 상태 표시
리뷰 카드 레이아웃
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MatchingResponse
participant ConsumerMatchingRepositoryImpl
participant PaymentViewModel
participant PaymentScreen
participant SsingMatchingDetailCard
MatchingResponse->>ConsumerMatchingRepositoryImpl: requesterName과 participants 전달
ConsumerMatchingRepositoryImpl->>PaymentViewModel: 매핑된 active model 제공
PaymentViewModel->>PaymentScreen: 참여자 목록과 equipmentStatus 설정
PaymentScreen->>SsingMatchingDetailCard: teamCount 전달
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
presentation/consumer-payment/src/main/java/com/ssing/presentation/consumerpayment/PaymentViewModel.kt (1)
49-62: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value장비 상태(
equipmentStatus) 하드코딩 여부 확인PR 요약에 서버 변경 사항을 반영하여 결제 화면의 장비 상태 처리를 업데이트했다고 명시되어 있으나, 현재
"착용 완료"로 하드코딩되어 있습니다. 의도된 임시 하드코딩인지, 아니면ConsumerMatchingActive.Active내의 상태 필드(예:itemStatus)를 매핑해야 하는 부분인지 확인을 권장합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@presentation/consumer-payment/src/main/java/com/ssing/presentation/consumerpayment/PaymentViewModel.kt` around lines 49 - 62, Update the equipmentStatus assignment in the PaymentViewModel mapping to use the equipment status field from ConsumerMatchingActive.Active, such as itemStatus, instead of the hardcoded "착용 완료" value; preserve the existing display mapping or fallback behavior used for status values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@presentation/consumer-home/src/main/java/com/ssing/presentation/consumerhome/ConsumerHomeViewModel.kt`:
- Around line 80-91: Update the ConsumerLessonCard.toCardStatus() mapping used
by toReservation() to inspect displayStatus instead of always returning
Status.Default. Map IN_PROGRESS to Status.Matching, matching
InstructorHomeViewModel, while preserving the existing default behavior for
other statuses.
---
Nitpick comments:
In
`@presentation/consumer-payment/src/main/java/com/ssing/presentation/consumerpayment/PaymentViewModel.kt`:
- Around line 49-62: Update the equipmentStatus assignment in the
PaymentViewModel mapping to use the equipment status field from
ConsumerMatchingActive.Active, such as itemStatus, instead of the hardcoded "착용
완료" value; preserve the existing display mapping or fallback behavior used for
status values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b96287b-078c-433c-a614-7b70479664c7
📒 Files selected for processing (8)
data/src/main/java/com/ssing/data/matching/consumermatching/model/ConsumerMatchingActive.ktdata/src/main/java/com/ssing/data/matching/consumermatching/remote/dto/response/ConsumerMatchingActiveResponse.ktdata/src/main/java/com/ssing/data/matching/consumermatching/repository/impl/ConsumerMatchingRepositoryImpl.ktpresentation/consumer-home/src/main/java/com/ssing/presentation/consumerhome/ConsumerHomeViewModel.ktpresentation/consumer-matching/src/main/java/com/ssing/presentation/consumermatching/component/InstructorProfileContent.ktpresentation/consumer-payment/src/main/java/com/ssing/presentation/consumerpayment/PaymentScreen.ktpresentation/consumer-payment/src/main/java/com/ssing/presentation/consumerpayment/PaymentViewModel.ktpresentation/instructor-home/src/main/java/com/ssing/presentation/instructorhome/InstructorHomeViewModel.kt
1 participant
Related issue 🛠
Work Description ✏️
홈에서 매칭 완료-준비 완료한 강습은 진행중이 아니라 NOW이다
결제화면 팀 이름, 강습인원/장비상태 누락필드 추가
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
Summary by CodeRabbit
새로운 기능
버그 수정