Skip to content

Run the cross-platform matrix on every PR #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TGPSKI wants to merge 1 commit into from
Closed

Run the cross-platform matrix on every PR #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,20 +142,24 @@ jobs:
run: ruff check .

# ─────────────────────────────────────────────────────────────────────────
# Cross-platform, full-scope checks.
# Triggers:
# - PR carrying the `full-test` label
# - manual `workflow_dispatch`
# - any push to `main`
# Cross-platform, full-scope checks. Runs on EVERY pull request.
#
# It used to be opt-in: a `full-test` label, a manual dispatch, or a push
# to main. Which meant a platform bug could only ever be discovered on
# main, after merging -- and that is exactly what happened, four pushes in
# a row, every one of them `windows/amd64`. The gate that was supposed to
# let you test portability before merging did not even fire on `labeled`,
# so in practice the only trigger was the one that runs too late.
#
# `needs: validate` still keeps these three runners idle when the fast
# gate is already red, so the cost is ~1 extra minute on a PR that was
# going to pass anyway. A permanently red main costs more than that: it
# trains everyone to stop reading CI, and then it stops being a signal at
# all.
# ─────────────────────────────────────────────────────────────────────────
full-scope:
name: Full-scope (${{ matrix.label }})
needs: validate
if: >-
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'pull_request' &&
contains(github.event.pull_request.labels.*.name, 'full-test')) ||
(github.event_name == 'push' && github.ref == 'refs/heads/main')
timeout-minutes: 20

strategy:
Expand Down