salvage(master): hopi spiral route generator + expanded tests - #114
Conversation
…ry tests Recovered from the legacy master branch before its deletion: a purely additive spiral search-route generator (Waypoint, SearchRoute, generate_spiral_route, destination_point, initial_bearing) for hopi_circles, plus the comprehensive test suites for hopi_circles and trajectory (the only content of master's 8 unique commits not already superseded by #108/#109/#111). All tests pass against current main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 93f4fb7. Configure here.
| math.cos(d_over_R) - math.sin(lat1) * math.sin(lat2) | ||
| ) | ||
|
|
||
| return (math.degrees(lat2), math.degrees(lon2)) |
There was a problem hiding this comment.
Longitude not normalized after destination
Medium Severity
destination_point returns math.degrees(lon2) without wrapping longitude to the conventional ±180° range. Near the antimeridian, consecutive circle waypoints can mix values above 180° with negative longitudes, so haversine_miles segment and route totals in generate_spiral_route and SearchRoute.segment_distances can be badly wrong for otherwise valid search centers.
Reviewed by Cursor Bugbot for commit 93f4fb7. Configure here.


Summary
Final salvage before the branch purge:
master's 8 unique commits are otherwise superseded (NEO clients → #108/#109; event log/space weather → #111; dated March-2026 event-scan snapshots), but its spiral route generator forhopi_circles(176 additive lines) and the expandedhopi_circles/trajectorytest suites are genuinely new. Purely additive; 156 affected tests pass.After this merges,
masteris deleted along with the 86 script-targeted branches.🤖 Generated with Claude Code
Note
Low Risk
Purely additive domain math and tests in meteor tracking; no API, auth, or data-store changes.
Overview
Adds ground-search navigation on top of existing Hopi concentric circles: labeled
Waypoint/SearchRoutemodels, geodesic helpers (destination_point,initial_bearing), per-circle waypoint placement, and a center-outward spiral that offsets each ring’s start bearing so routes interleave instead of stacking rings.generate_spiral_routeis the main entry point (builds circles, thenSearchPattern.generate_spiral_route), with Lexicon-styleto_prayer_stringoutput and total route mileage. The legacygenerate_waypoints_on_circletuple API is left in place.New
test_hopi_circlesandtest_trajectorysuites cover geodesic math, spiral geometry, max-radius limits, and an integration path fromcalculate_trajectorydebris centers into spiral routes.Reviewed by Cursor Bugbot for commit 93f4fb7. Bugbot is set up for automated code reviews on this repo. Configure here.