docs: write down exit-code roles and the smoke coverage model - #139
Merged
Conversation
The missing convention was the defect behind #136, not exit 9. Records per-script 0/2/3+, FATAL 1, smoke 0/1/77, and that blender-smoke has no push trigger on purpose. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #136 as an invalid premise, not as a code bug.
Exit 9 is within
2+. 26 example scripts use 9 for a sequential check.export-preset-axis --same-axisexiting 9 is the documented falsifier. No executable code changed. Noneeds-5.1label: this PR makes no three-version claim.Where it landed
CONTRIBUTING.md(Exit codes + expanded Blender smoke). That is the existing contributor-conventions file (version targeting, smoke lever, DCO). Nostandards/directory in this repo.AGENTS.mdonly points here so agents do not grow a second copy.Task 1 (live-run-proven this session)
Commands:
rg -n "sys\.exit|SystemExit|exit\(" --type py(workspace Grep), then an AST walk overe:\Blender-Developer-Tools\**/*.pyexcluding.git/.scratch/docs. Assert-on-9: Grep inblender-smoke.yml,tests/,scripts/.gltf-export-roundtripsys.exit(1)FATAL wrapperssys.exit(1)(54 examples + 3tests/+scripts/site/build_site.py). 64 is any integer literal1includingreturn 1return 1; docs use the role, not the 640/1/77run_example.pyfail=return 1;check_import_export_rules.pyreturn 1;canary_skip.pysys.exit(77);gn-bundle-roundtripandexit-pre-sidecarreturn 77+SMOKE_SKIP:tests/andscripts/: no hits.blender-smoke.yml: only[0-9]+in the Blender tarball regexinspection-only: no-mesh is 2 vs 5 in the two headless templates (read
script.py/pipeline.py).Out of scope (unchanged)
Any exit value.
export-preset-axisbehavior. New rule/checker/validate.yml. Bake/UV. Agent bridge. LICENSE / #131. VERSION / CHANGELOG / release.yml.blender-smoke.yml/pages.ymlfiles.Follow-up (report-mode README check, not this PR): #138.