fix(showcase): grindstone and wheelbarrow visual quality pass - #174
Merged
Merged
Conversation
AABB zmin cannot catch a planted wheel hiding floating shoes. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…lly join The trestle was two sticks with a hole under the bearing and a floating tub. King, nested sill, manifold basin, and shoe tenons close the joints, locked as hygiene and seat budgets. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ctually meet Walls sat on the floor and spokes were audited against floor slats. Seated walls, nested handles, and a hub-local spoke metric lock the joints. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
The README exit-table check treats return -1 as a process code. Missing material is None. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Showcase visual quality pass on grindstone and wheelbarrow — the two worst remaining after chopping-block. Structural generator fixes, then hygiene / named-support / joint-fit / seat budgets with falsifiers proven on 4.5.11, 5.1.2, and 5.2.1.
showcase/README.mdnow requires named supports (exit 16) on multi-foot props.Grindstone
Defects (inspection sheet)
ortho_front,ortho_back,joint_aframe_peak.ground_contact,ortho_bottom.joint_aframe_peak,clay_a.ortho_top,joint_crossbrace,three_quarter_a.Generator fixes (structural)
inset_region/extrude_face_region) instead of five overlapping boxes; bevel only the trough.TROUGH_Wderived from the sill inner face plus a seat; end stretchers tenon through both sills at sill height.--narrow-trough/--float-legs/--short-legsas named falsifiers.--float-crankmoves the crank inward so the Y AABB stays in band;--no-diplowers the trough instead of raising the stone.Budgets (all three binaries)
Falsifiers (same code on all three)
--skip-decimate--stray-vert--lift-z--short-legs--float-crank--float-legs--no-dip--narrow-troughInspection rounds: 7. Framing on 5.2.1: fill y=0.722, margins ≥ 0.056,
framing_ok.Wheelbarrow
Defects (inspection sheet)
ortho_front,joint_tray_bottom.joint_handle_tray,clay_a.spoke_clearancematched floor slats, so--fat-spokescould not fail the hub budget.--pipe-rimused an inner metal torus that floated (tyre_z=0.008) and hit exit 16 before tread aspect.--float-wallsat a zero seat welded four doubles, so hygiene 15 fired before seat 17.Generator fixes (structural)
WALL_SEAT).--float-wallsuses a small negative seat so walls lift without kissing/welding.Budgets (all three binaries)
Falsifiers (same code on all three)
--skip-decimate--stray-vert--lift-z--short-legs--fat-spokes--float-walls--pipe-rimInspection rounds: 6. Framing on 5.2.1: fill y=0.728, margins ≥ 0.067,
framing_ok.Test plan
check_framingwithoutdeviation=,framing_ok