fix(showcase): iron-cauldron and shipping-crate visual quality pass - #176
Merged
Merged
Conversation
World-Z cups let leaning poles slice the lip. Coaxial shoes plus pole-axis bite keep the joint closed without a magic offset. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…iene budgets Posts hung over a skid cave and 90-degree handle lofts sat on the plates. Shared post/skid planes and quarter-circle bails close those joints without magic offsets. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual quality pass on iron-cauldron and shipping-crate (worst remaining after grindstone/wheelbarrow then treasure-chest/tavern-stool). Inspection sheets in
.scratch/(untracked). Three rounds plus a 3b verify of unfinished structural fixes.showcase/README.mdalready had hygiene conventions — no extra commit.Picked because they had no hygiene section and the heroes hid the joints (flattering three-quarter with materials on).
iron-cauldron
Defects (inspection)
Generator fixes (structural)
shifted + tangent * (FERRULE_FLOOR + 0.002)— shared plane, not a magic Z.ferrule_biteuses pole-axis radius and only samples wood inside the cup's own axis span, so a pole hovering above the well cannot fake a seat.--pipe-ferrulekeeps the same cup and lifts the pole above the well so the falsifier hits exit 18 only (not zmin/AABB/supports first).Hygiene (all three binaries)
Non-manifold/loose/doubles/zero-area/n-gons/z-fight 0. zmin 0. 3 cups at z 0. Bite −0.00185. Hook gap 0. Pot 0.3545 × 0.3340 m. Clearance 0.0464. Collider 250. Export 287916 / 287916 / 287904.
Defaults 0.
--skip-decimate9.--stray-vert15.--lift-z/--short-legs16.--float-hook17.--pipe-ferrule18.Tris 3388 → 3664. Framing fill y 0.750, margins ≥ 0.02 (no
deviation=). Inspection rounds: 3 + 3b.Hero still reads as a hanging iron pot on a timber tripod. Faceted ear pipes remain a nit.
shipping-crate
Defects (inspection)
Generator fixes (structural)
--short-skidsliftsskid_z0to 0.055 (0.04 made skid tops coplanar with sills → zfight 4, exit 15 before 16).--omit-slatshits exit 18 only.Hygiene (all three binaries)
Non-manifold/loose/doubles/zero-area/n-gons/z-fight 0. zmin 0. 3 skids at z 0. Handle gap 0. Slat-post gap 0. Body 1.056 × 0.716 m. Collider 76. Export 197408 / 197408 / 197392. LOD2 0.2193 / 0.2193 / 0.2057.
Defaults 0.
--skip-decimate9.--stray-vert15.--lift-z/--short-skids16.--float-handle17.--omit-slats18.Tris 624 → 2508. Framing fill y 0.728, margins ≥ 0.02. Inspection rounds: 3 + 3b.
Hero still reads as a post-and-slat shipping crate. Nits: handle plates straddle a slat gap; L-straps do not wrap onto the sill; bail still faceted.
Evidence
--outputon 5.2.1 with framing gate..scratch/qpass/{cauldron,crate}/round-{1,2,3,3b}/(not committed).python scripts/build_gallery.py→ 77 pages; alts/witnesses read back.Test plan
needs-5.1applied via REST; 5.1 smoke job appears