fix(showcase): market-stall and watchtower visual quality pass - #179
Merged
Merged
Conversation
…ning Capped foot cubes and counter-leg pads z-fought at Z=0, and braces punched the counter. Wrap plates and a post-bay brace plane are durable; per-coordinate nudges are not. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…d stiles Incomplete courses left a wood U through the eave, and shoes lifted after the zmin snap. A solid cone plus post-snap collars are durable; per-coordinate nudges are not. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual quality pass on market-stall and watchtower — the two largest remaining pieces that had never had one. Four inspection rounds on 5.2.1 (round 3 still showed a wood-U roof and a floating ladder pad; round 4 closed both). Fixes are in the generators. Hygiene 15–19 already live in
showcase/README.md; this PR does not change that file.Picks: never-passed. Next run should take stone-well / street-lantern (largest remaining unpassed silhouettes).
Market stall
Defects (inspection sheet, rounds 1–3)
round(cx*4)/4) — audit, not a silhouette defect.Generator fixes (structural)
add_wrap) stand off the post byhalf + t/2 + 0.002; Y-plates spanhost+2tso corners meet without coplanar overlap. No capped foot cube.FRONT_H+0.012/BACK_H+0.012; seat measures stripe faces withzmax > FRONT_Hso the valance top cannot pass as the canopy.sin(i)increased; front roller/hem added.(sign(cx), sign(cy)).Hygiene (all three binaries)
Before/after tris: 4404 → 4324.
Falsifiers (same code on 4.5.11, 5.1.2, 5.2.1)
--skip-decimate--stray-vert--lift-z--short-feet--low-brace--float-awning--rake-postsInspection rounds: 4. Framing on 5.2.1: fill y=0.783, margins min 0.056. No
deviation=. Landing-page-worthy.Watchtower
Defects (inspection sheet, rounds 1–3)
PLAN_XYwas the post bay (1.13 m) against an eave AABB of 1.594 m — would have fired 19 on a correct plan.Generator fixes (structural)
t0=(row+0.14)/N,t1=min(0.96,(row+1)/N), offset along face normal so peak/eave verts are not doubled.z<0.005→ 0).section = POST*0.70so end verts are not on post faces.k*(BRACE_T+0.008).PLAN_XY = 2*EAVE_HALF. Camera pulled back 1.55/2.15 → 1.98/2.75 for the taller roof.Hygiene (all three binaries)
Before/after tris: 5220 → 6408 (taller eave-true roof and coursed shakes, not hidden faces). Collider ceiling 80 → 180 to match the new pyramidal silhouette (measured 150).
Falsifiers (same code on 4.5.11, 5.1.2, 5.2.1)
--skip-decimate--stray-vert--lift-z--short-shoes--short-rails--float-band--rake-postsInspection rounds: 4. Framing on 5.2.1: fill y=0.767, margins min 0.083. No
deviation=. Landing-page-worthy.Test plan
deviation=needs-5.1via REST), 5.2