Rename Weekly Review's "Projects" step to "Next Actions" and broaden snapshot (#290)

[trixy-the-ai-bot]

Summary

• Renamed Weekly Review's third step from "Projects" to "Next Actions" across all internal symbols (class, file, fields, step constant, methods, flags) to match the user-visible copy that was already updated.
• Broadened the step's snapshot to iterate all active next actions instead of only project-tagged ones, since full Projects support doesn't exist yet and the old filter no longer matched the framing.
• Excluded person-tagged next actions from the snapshot at the SQL layer via the new TodoDao.getNextActionsExcludingPersonTagged(), enforcing the disjointness invariant (each task surfaces in at most one wizard step) so Waiting For and Next Actions no longer overlap.
• Removed the now-dead getNextActionsWithProjectTags() DAO method and updated empty-state copy/icon plus header comments in projects_step.dart (renamed to next_actions_step.dart), periodic_review_screen.dart, and _review_card.dart.
• Updated docs/ARCHITECTURE.md and docs/REQUIREMENTS.md to reflect the new step name, the broadened snapshot, and the disjointness invariant with its person-tag exclusion.

Test plan

• flutter analyze is clean.
• Existing periodic-review tests pass.
• New test: a person-tagged next action surfaces in Waiting For snapshot and NOT in Next Actions snapshot.
• New test: a non-person-tagged next action surfaces in Next Actions snapshot only.
• Manual: walk Weekly Review through Inbox → Waiting For → Next Actions → Someday/Maybe → Summary, confirming each task surfaces in at most one step.
• Verify summary stats tally correctly (nextActionsReviewed).

🤖 Generated with Claude Code

Closes #290

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b5279d11-45ed-4e61-9ba1-689b26860aa0

📥 Commits

Reviewing files that changed from the base of the PR and between 67055ec and 2ae895a.

📒 Files selected for processing (11)

• NOTES.md
• app/lib/database/daos/todo_dao.dart
• app/lib/providers/periodic_review_provider.dart
• app/lib/screens/periodic_review/periodic_review_screen.dart
• app/lib/screens/periodic_review/steps/_review_card.dart
• app/lib/screens/periodic_review/steps/next_actions_step.dart
• app/lib/screens/periodic_review/steps/summary_step.dart
• app/test/database/todo_dao_test.dart
• app/test/integration/periodic_review_flow_test.dart
• docs/ARCHITECTURE.md
• docs/REQUIREMENTS.md

---

Walkthrough

This PR addresses issue #290 by renaming the Weekly Review wizard's third step from "Projects" to "Next Actions" and implementing a behavior change: the step now reviews all active next actions while excluding person-tagged items to enforce the disjointness invariant. The DAO gains a new getNextActionsExcludingPersonTagged() method (with SQL-layer exclusion), and the old getNextActionsWithProjectTags() is removed. Provider state, screen navigation, step widget, summary display, and all supporting tests and documentation are updated correspondingly.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related issues

• #289: Both changes introduce NOT EXISTS predicates on person-tagged todos in the DAO to enforce disjointness; this PR's getNextActionsExcludingPersonTagged() directly addresses the next-actions side of the invariant.

Possibly related PRs

• TMaYaD/Jeeves#273: Precursor that likely introduced the "Projects" step or related wizard infrastructure that this PR refactors and renames.

Suggested labels

domain-modelling, engineering

Suggested reviewers

• TMaYaD
• capo-the-ai-bot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: renaming the Weekly Review's 'Projects' step to 'Next Actions' and broadening the snapshot scope.
Description check	✅ Passed	The description provides relevant context explaining the renaming, behavior changes, dead-code removal, documentation updates, and test plan for the pull request.
Linked Issues check	✅ Passed	The pull request implementation meets all coding requirements from issue #290: renamed symbols and files from Projects to Next Actions, changed loader to include all active next actions excluding person-tagged items using new DAO method, removed dead code, updated comments and UI copy, added comprehensive test coverage for disjointness.
Out of Scope Changes check	✅ Passed	All changes are in scope: symbol renames, DAO method changes, state management updates, UI screen updates, step file renaming, documentation updates, and test additions all directly support the issue #290 objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-290/rename-weekly-review-s-projects-step-to-next-actio

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}