Repository navigation
fix(tradingagents): preserve configured timeouts and expose provider errors - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
TradingAgents configurations saved by the UI include
auto_trigger, which the agent constructor did not accept. The execution entry point caught the resulting TypeError and silently created a default agent, resetting a configured 600-second model timeout to 300 seconds. Provider failures such as GLM HTTP 400/code 1301 were also replaced with a generic request error, hiding the actionable reason.Changes
AgentConfig.configORM field, and log effective timeout and model settings.Validation
.venv/bin/python -m pytest tests/test_ai_errors.py tests/test_tradingagents_agent.py tests/test_tradingagents_auto_trigger.py tests/test_tradingagents_progress_recovery.py tests/test_tradingagents_v050_compat.py tests/test_tradingagents_trigger_idempotency.py -q— 86 passed.pnpm --dir frontend exec vitest run tests/analysis/deep-analysis-modal.test.tsx tests/settings/deep-analysis-timeouts.test.tsx— 9 passed.check:ui,check:i18n,check:market-colors, andbuild— passed.git diff --check origin/main...HEAD— passed.Boundaries and risks
.docs/are excluded from this PR.Follow-up
None required for this release.