Conversation
Payment and monitoring
AHHHHHHHHHHHHHHH
Merge dev
…ntation was added to the pom
There was a problem hiding this comment.
Pull request overview
This PR adds Swagger/OpenAPI support to the application using springdoc-openapi and improves the logging infrastructure by migrating from bind-mounted logs to Docker named volumes.
Key changes:
- Added springdoc-openapi-starter-webmvc-ui dependency (version 2.3.0) for API documentation
- Migrated application logs from bind-mounted directory (
./logs) to Docker named volume (app-logs) - Added cleanup step in deployment workflow to remove old logs directory
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml | Added springdoc-openapi-starter-webmvc-ui dependency for Swagger/OpenAPI support |
| docker-compose.yml | Changed log storage from bind mount to named volume for both app and promtail services; added app-logs volume definition |
| .github/workflows/sonarcloud.yml | Added pre-checkout cleanup step to remove old logs directory, ensuring clean deployment state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <dependency> | ||
| <groupId>org.springdoc</groupId> | ||
| <artifactId>springdoc-openapi-starter-webmvc-ui</artifactId> | ||
| <version>2.3.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
The springdoc-openapi dependency has been added, but the SecurityConfig needs to be updated to permit access to Swagger UI endpoints. Without this, users won't be able to access the Swagger documentation at the default paths like /swagger-ui.html, /swagger-ui/, /v3/api-docs/, and /api-docs/**. These paths should be added to the permitAll() list in SecurityConfig.java alongside other public endpoints.
|
Added swagger support