Merged
Conversation
Captures all Phase 0 (Foundation & Planning) deliverables, tasks, and their completion status in a single actionable checklist. Includes the domain survey, scope definition, architecture overview, data structure spec, technology stack decisions, testing/documentation strategies, risk register, and transition criteria to Phase 1. https://claude.ai/code/session_01SSdbmodGkPH5K3gbYQn86e
Documents the full current state of Phase 1 implementation (137 tests passing) and identifies the 10 remaining tasks: packaging sub-package discovery fix, save_ascii_1d, subtract_background, three unimplemented visualization functions (plot_guinier/porod/fit), artifact cleanup, tutorial notebook, GitHub Actions CI, and associated tests. Includes priority order, per-task specs, and completion criteria. https://claude.ai/code/session_01SSdbmodGkPH5K3gbYQn86e
…zation, CI - pyproject.toml: switch to find-packages discovery so all sub-packages (processing, analysis, modeling, …) are included in the installed wheel - scatterbrain/processing/background.py: new subtract_background() supporting constant offsets and curve backgrounds with optional interpolation and scale_factor; error propagation in quadrature - scatterbrain/processing/__init__.py: expose subtract_background - scatterbrain/io.py: implement save_ascii_1d() with auto-generated comment header, optional error column, configurable delimiter/format, and full round-trip compatibility with load_ascii_1d() - scatterbrain/visualization.py: replace three NotImplementedError stubs with working implementations of plot_guinier, plot_porod, and plot_fit; each accepts an optional analysis/fit result dict for overlay and annotation - scatterbrain/visualization_renamed/: remove stale artifact (git rm) - notebooks/01_basic_workflow.ipynb: end-to-end tutorial covering load → background subtraction → Guinier → Porod → sphere fit → save - .github/workflows/ci.yml: GitHub Actions CI matrix (py3.10/3.11/3.12) with black, flake8, mypy, pytest+coverage, and Sphinx docs build steps - tests/test_processing.py: 20 unit tests for subtract_background - tests/test_io.py: 7 new tests for save_ascii_1d including round-trip check - tests/test_visualization.py: replace skipped placeholder tests with 25 working tests for plot_guinier, plot_porod, and plot_fit All 183 tests pass. https://claude.ai/code/session_01SSdbmodGkPH5K3gbYQn86e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures all Phase 0 (Foundation & Planning) deliverables, tasks, and
their completion status in a single actionable checklist. Includes the
domain survey, scope definition, architecture overview, data structure
spec, technology stack decisions, testing/documentation strategies, risk
register, and transition criteria to Phase 1.
https://claude.ai/code/session_01SSdbmodGkPH5K3gbYQn86e