Moved 'Friends' tab & added error handling. - #1
Open
zerodivide1 wants to merge 2 commits into
Open
Conversation
Also changed icons.
Added error handler & displayed pop-up message when there is an error while loading the Friends list. Refactored the $http request to use the fluent method calls "success" and "error" for readability.
zerodivide1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the 'Friends' tab is the first tab, it seemed logical to have the tab on the left side of the tab bar. Also changed the icons used.
Also added error handling for the friends list and displayed an error pop-up if the Friends list could not be loaded.