chore(vscode-webui): stop passing full message array to tool parts - #1903
Merged
Conversation
Every tool part received the whole formatted renderMessages array, whose identity changes on each streaming tick, defeating memoization for all tool parts. Only attemptCompletion and renderWidget consumed it, and both only needed to know their position, so replace it with two booleans derived once per part: the existing isLastPart and a new isInLastAssistantMessage. 🤖 Generated with [Pochi](https://getpochi.com) Co-Authored-By: Pochi <noreply@getpochi.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1903 +/- ##
==========================================
+ Coverage 38.30% 38.31% +0.01%
==========================================
Files 772 772
Lines 82410 82354 -56
Branches 3951 4015 +64
==========================================
- Hits 31566 31556 -10
+ Misses 50727 50681 -46
Partials 117 117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every tool part received the whole formatted renderMessages array, whose identity changes on each streaming tick, defeating memoization for all tool parts. Only attemptCompletion and renderWidget consumed it, and both only needed to know their position, so replace it with two booleans derived once per part: the existing isLastPart and a new isInLastAssistantMessage.
🤖 Generated with Pochi