fix: preview SQL popover not presenting from toolbar button#740
Merged
fix: preview SQL popover not presenting from toolbar button#740
Conversation
Move .popover() from the disabled Button to an always-enabled VStack wrapper so SwiftUI can anchor the popover regardless of button state. Also remove attachmentAnchor: .point(.bottom) which caused incorrect positioning in macOS toolbars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Preview SQL" toolbar popover (eye icon / Cmd+Shift+P) never presents on macOS. Root cause:
.popover(isPresented:)attached to a.disabled()button is silently ignored by SwiftUI — even when the binding is set programmatically.Fix
Move
.popover()from the disabledButtonto an always-enabledVStackwrapper so SwiftUI can anchor the popover regardless of button state.Also removes
attachmentAnchor: .point(.bottom)which caused incorrect anchor positioning in macOS toolbars.Why this is correct
VStackwith a single child is a layout no-op — identical frame as the button.disabled()stays on theButton— native grayed-out appearance and VoiceOver semantics preserved.help()stays on theButton— tooltip properly associated.rect(.bounds)) works correctly in toolbarsTest plan