fix: backport precompile state-override fix (evm v0.6.0-tac.13) - #90
Merged
Conversation
Backports upstream cosmos/evm #1096. A state override on eth_call replaced the
whole precompile set with go-ethereum's stock one, so the static precompiles
were dropped: any eth_call carrying overrides — an empty {} was enough —
returned empty output for a precompile address instead of the real result, with
no error. Upstream fixed it in 0.7.x and never backported to 0.6.x.
Also affects tac_simulate, whose gas estimate was ~4.6x too low on precompile
calls for the same reason.
Adds the upstream #1096 backport that came in with tac.13, and moves the fork
table from tac.12 to tac.13.
Worth calling out on its own because it is the one item here that describes a
bug live on v1.6.0: an eth_call carrying state overrides — an empty {} was
enough — silently returned 0x for a precompile address instead of the real
result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the evm fork to
v0.6.0-tac.13, which backports upstream cosmos/evm #1096.A state override on
eth_callreplaced the whole precompile set withgo-ethereum's stock one, so a call to a precompile address returned
0xwith noerror — an empty
{}was enough to trigger it.