Fix arm-deployments split SDK client#104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arm-deploymentsto the split Azure deployments management client introduced by the currentazure-mgmt-resourcepackagearm-deploymentscollector pathRoot cause
azure-mgmt-resource 25.0.0moved deployment operations offResourceManagementClientintoDeploymentsMgmtClientfromazure-mgmt-resource-deployments. AzureFox had already absorbed the subscriptions split, butarm-deploymentswas still callingself.clients.resource.deployments, which now raises'ResourceManagementClient' object has no attribute 'deployments'and empties the command output.Verification
ruff check src/azurefox/clients/factory.py src/azurefox/collectors/provider.py tests/test_clients_factory.py tests/test_collectors.pypytest tests/test_clients_factory.py tests/test_collectors.py -qAZURE_CONFIG_DIR=/tmp/azurefox-azure-config PYTHONPATH='/Users/cfarley/Documents/HarrierOps/Azure/Family AF/AzureFox/src' /tmp/azurefox-runtime-compat-venv/bin/python -m azurefox --subscription b436881a-b87e-44b6-a5d6-7bf7f4bc9c88 --output json arm-deploymentsPYTHONPATH=src python3 -m pytest -m "not integration"->413 passed, 2 deselectedNote