Skip to content

Fix arm-deployments split SDK client#104

Merged
TacoRocket merged 1 commit into
mainfrom
fix/arm-deployments-client-split
Apr 18, 2026
Merged

Fix arm-deployments split SDK client#104
TacoRocket merged 1 commit into
mainfrom
fix/arm-deployments-client-split

Conversation

@TacoRocket
Copy link
Copy Markdown
Owner

Summary

  • switch arm-deployments to the split Azure deployments management client introduced by the current azure-mgmt-resource package
  • add the new default dependency so editable installs include the runtime client automatically
  • add regression coverage for both the client factory and the arm-deployments collector path

Root cause

azure-mgmt-resource 25.0.0 moved deployment operations off ResourceManagementClient into DeploymentsMgmtClient from azure-mgmt-resource-deployments. AzureFox had already absorbed the subscriptions split, but arm-deployments was still calling self.clients.resource.deployments, which now raises 'ResourceManagementClient' object has no attribute 'deployments' and empties the command output.

Verification

  • ruff check src/azurefox/clients/factory.py src/azurefox/collectors/provider.py tests/test_clients_factory.py tests/test_collectors.py
  • pytest tests/test_clients_factory.py tests/test_collectors.py -q
  • AZURE_CONFIG_DIR=/tmp/azurefox-azure-config PYTHONPATH='/Users/cfarley/Documents/HarrierOps/Azure/Family AF/AzureFox/src' /tmp/azurefox-runtime-compat-venv/bin/python -m azurefox --subscription b436881a-b87e-44b6-a5d6-7bf7f4bc9c88 --output json arm-deployments
  • repo pre-push guardrail: PYTHONPATH=src python3 -m pytest -m "not integration" -> 413 passed, 2 deselected

Note

  • repo-preferred clean-context CCR was not run because this session does not permit subagent delegation unless explicitly requested

@TacoRocket TacoRocket merged commit efa6c82 into main Apr 18, 2026
7 checks passed
@TacoRocket TacoRocket deleted the fix/arm-deployments-client-split branch April 18, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant