Fix chains live viewpoint blockers#105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
chainsfamily runs degrade into surfaced issues and still emit artifacts when a supporting collector fails instead of aborting before output writeWhy
The live Terraform lab exposed two blockers in AzureFox itself:
whoamisubscription context intopermissions, which then overstatedchains escalation-pathValidation
python3 -m ruff check src/azurefox/scope_hints.py src/azurefox/permissions_hints.py src/azurefox/collectors/provider.py src/azurefox/collectors/commands.py src/azurefox/chains/runner.py src/azurefox/chains/compute_control.py tests/test_collectors.py tests/test_chain_semantics.py tests/test_cli_smoke.pyPYTHONPATH=src pytest -q tests/test_collectors.py -k "collect_permissions or permissions_current_identity" tests/test_chain_semantics.py -k "escalation" tests/test_cli_smoke.py -k "deployment_path or escalation_path or compute_control" tests/test_compute_control.pyPYTHONPATH=src git push -u origin fix/chains-live-viewpoint-blockersran repo lint plus417 passed, 2 deselectedNotes