Open
Conversation
Owner
|
Thank you so much for this PR! But can you please update it to follow the new examples in v1.0? For consistency, it's better if it follows the same layout and styles; so it's only different in how the framework is used. |
|
It should probably use a ref instead of grabbing element by class. And then a side note, does it make sense to use local storage in the example? To me it's cool to have an example, but it's also a preference to use localStorage to save it, so potentially it bloats the example making it harder to read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Qwik example of swapy based on /example/react/