4 add gridlines to format2d#6
Merged
Merged
Conversation
Closed
TalbotKnighton
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored trendify API for future growth (closes #5). Decided not to fix type hints since trendify 2.0 is coming soonish.
Also added Grid support to Format2D using
GridandGridAxis(closes #4). Users can simply incorporate prepackaged format using enumeratedGridTheme(GridTheme.MATLABis my personal favorite). The default behavior will still be no grid.One known issue is that the major gridlines plot in front of lines, but its not very noticeable with a very transparent grid. I think its an issue with matplotlib 3.10.3 cause I cannot figure out how to fix it. You can sort of fix it be declaring a higher zorder for the other lines you want to be on top of the gridlines.