Skip to content

feat(ui): trap and restore focus in settings panel#72

Merged
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
AlonsoFi:a11y/settings-focus-management
Jun 2, 2026
Merged

feat(ui): trap and restore focus in settings panel#72
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
AlonsoFi:a11y/settings-focus-management

Conversation

@AlonsoFi

@AlonsoFi AlonsoFi commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Closes #61
Implements all focus management requirements from issue

  • Focus trap: Tab and Shift+Tab cycle within the open panel, never reaching the page behind
  • Escape key: closes the panel from any state
  • Initial focus: close button receives focus when the panel opens
  • Focus restoration: trigger button regains focus when the panel closes by any means
  • Dialog semantics: role="dialog", aria-modal="true", aria-labelledby bound to the visible heading

Tests (Jest + RTL): 7 new a11y tests added, 21/21 passing
Lint: no warnings or errors
Build: clean production build, types valid

Keyboard flow verified:
Open panel → Tab through all controls → Tab past Done wraps to close button
→ Escape closes → gear trigger regains focus

@drips-wave

drips-wave Bot commented Jun 2, 2026

Copy link
Copy Markdown

@AlonsoFi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mikewheeleer mikewheeleer merged commit bef408a into Talenttrust:main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit and fix focus management in SettingsPanel and SettingsTrigger

2 participants