feat: handle delete-insert in transaction merging #1068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
So related to the whole longer lived editing session concept, running into delete and the insert issue on pending mutation. Basically if user deletes something in our editor, we tx.mutate and delete the record. Then if the user cmd+z to undo in our editor, we reverse the operation and insert the record that was just deleted (on same tx, it has not been committed yet).
This pattern results in the Uncaught Error: Unhandled mutation combination: delete-insert error.
This PR adds handling for delete-insert pattern.
✅ Checklist
pnpm test:pr.🚀 Release Impact