fix(adapters): make shallow equality handle Temporal value objects #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
shallowequality to avoid treating all “keyless” objects as equal (Temporal objects expose no enumerable keys)..equals()when available (e.g. Temporal).Why
The adapters default to
shallowequality. Previously,shallowcould returntruefor two different object instances if both had zero enumerable keys, because there were no keys to compare. Temporal types fromtemporal-polyfillare keyless, so updates to Temporal values could be incorrectly treated as “unchanged” and skip UI updates.Behavioral notes
{}vs[]is now treated as not equal (previously could be considered equal due to both being “keyless”).Object.is), or.equals()(Temporal), in which case.equals()is used.Consumers can still provide
options.equalfor custom semantics.Related issues
Fixes:
TanStack/form#1628
#218
Verification in downstream
✅ Checklist
pnpm test:pr.🚀 Release Impact