🎨 Palette: Add accessibility labels to close buttons#126
🎨 Palette: Add accessibility labels to close buttons#126TargetMisser wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What: Added
accessible={true},accessibilityRole="button", andaccessibilityLabel={t('close')}to theTouchableOpacitycomponents used for close buttons inDrawerMenu.tsxandShiftTimeline.tsx. Also added the newclosetranslation string tosrc/i18n/translations.ts.🎯 Why: Icon-only buttons without an accessible label are invisible or incorrectly read by screen readers. By adding an
accessibilityLabeland thebuttonrole, users relying on assistive technologies can now understand the purpose of these close buttons, making the app more accessible.📸 Before/After: Not applicable (non-visual change).
♿ Accessibility: Improved screen reader support for closing the drawer menu and the shift timeline modals by providing meaningful text ('Chiudi' or 'Close') instead of an unlabelled view.
PR created automatically by Jules for task 14288312750910702415 started by @TargetMisser