🎨 Palette: Improve accessibility and UX of NotepadScreen buttons#137
🎨 Palette: Improve accessibility and UX of NotepadScreen buttons#137TargetMisser wants to merge 1 commit intomainfrom
Conversation
Added missing accessibility properties (accessible, accessibilityRole, accessibilityLabel) and hitSlop to the icon-only delete button in NotepadScreen to make it usable with screen readers and easier to tap. Also disabled the save button when the state is already saved and correctly passed the accessibilityState to assistive technologies. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What: Added
accessible,accessibilityRole,accessibilityLabel, andhitSlopto the icon-only "Clear notes" button in NotepadScreen. Disabled the save button when there are no unsaved changes, passingaccessibilityState={{ disabled: saved }}to screen readers.🎯 Why: Icon-only buttons without labels are completely invisible or un-descriptive to screen readers. Small touch targets make mobile usage frustrating. A visually disabled save button should also be programmatically disabled to prevent redundant actions and accurately reflect state to assistive tech.
📸 Before/After: Not a visual change, but the clear button touch area is larger and the save button cannot be clicked repeatedly when already saved.
♿ Accessibility: Yes, improves screen reader support for the clear button and conveys state properly for the save button.
PR created automatically by Jules for task 3245120515463329003 started by @TargetMisser