2.6.25#146
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7668750825
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "build-tools;36.0.0" \ | ||
| "platforms;android-36" \ | ||
| "build-tools;37.0.0" \ | ||
| "platforms;android-37.0" \ |
There was a problem hiding this comment.
The workflow installs "platforms;android-37.0", but sdkmanager expects SDK-style package IDs like "platforms;android-36" (Android docs show this exact format). Using the .0 suffix makes the package path invalid, so CI release builds can fail before Gradle runs when this step executes.
Useful? React with 👍 / 👎.
|
|
||
| return ( | ||
| <Modal visible transparent animationType="fade" onRequestClose={onDismiss}> | ||
| <Modal visible transparent animationType="fade" onRequestClose={downloadState === 'downloading' ? undefined : onDismiss}> |
There was a problem hiding this comment.
When downloadState === 'downloading', onRequestClose is set to undefined, but React Native requires this callback on Android while a Modal is open (hardware back handling depends on it). In this state, pressing back can trigger runtime warnings/errors instead of a controlled no-op, so the modal should keep a defined handler and gate dismissal inside that function.
Useful? React with 👍 / 👎.
1 participant
What Changed
Describe the outcome of the change in a few lines.
Checklist
Screenshot or Video
If the change affects UI or UX, attach something here.
Review Notes
Call out sensitive areas, open questions, or review focus points here.