Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in WebView data transfer#147

Open
TargetMisser wants to merge 1 commit intomainfrom
sentinel-fix-webview-xss-4161462877144964331
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in WebView data transfer#147
TargetMisser wants to merge 1 commit intomainfrom
sentinel-fix-webview-xss-4161462877144964331

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH

πŸ’‘ Vulnerability: React Native applications passing user-provided data into a WebView component via the injectJavaScript function are exposed to Cross-Site Scripting (XSS). If user data (such as arbitrary images converted to base64 JSON representation) is executed inline via string interpolation inside the webview JS context, this creates a vector where attackers might manipulate the input format to execute arbitrary malicious JS within the WebView.

🎯 Impact: An attacker who can forge or manipulate the image data (or base64 string metadata) fed to the WebView could execute arbitrary JS code, steal cookies/storage, or further abuse the bridge context.

πŸ”§ Fix:

  • Replaced the insecure injectJavaScript(jsCode) data-passing mechanism in both HomeScreen.tsx and ShiftScreen.tsx with webViewRef.current?.postMessage().
  • Registered explicit JS event listeners (document.addEventListener("message", ...) and window.addEventListener("message", ...)) within the HTML templates of the WebViews to securely capture and evaluate the JSON strings sent as event.data.

βœ… Verification: Run npm run typecheck and npx jest --passWithNoTests to confirm that standard build scripts haven't regressed. Evaluated via Code Review.


PR created automatically by Jules for task 4161462877144964331 started by @TargetMisser

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 Apr 30, 2026 1:38am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant