Skip to content

🎨 Palette: Enhance flight card haptics and accessibility#153

Open
TargetMisser wants to merge 2 commits intomainfrom
palette/flight-card-ux-a11y-17306194628253588093
Open

🎨 Palette: Enhance flight card haptics and accessibility#153
TargetMisser wants to merge 2 commits intomainfrom
palette/flight-card-ux-a11y-17306194628253588093

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

💡 What: The UX enhancement added

This PR enhances the flight card interactions on the FlightScreen by adding tactile haptic feedback to swipe gestures and significantly improving accessibility for screen reader users.

🎯 Why: The user problem it solves

  1. Physical Feedback: Users swiping to pin a flight now receive physical confirmation through haptics when the swipe threshold is reached and when the action completes, making the interface feel more responsive and "alive."
  2. Accessibility Inclusion: Swipe gestures are inherently difficult or impossible for screen reader users to discover and use. By adding standard accessibilityActions, users can now toggle the pinned status of a flight through their device's accessibility menu (e.g., TalkBack or VoiceOver).
  3. Information Density: Consolidates multiple pieces of flight information (status, times, locations) into a single, cohesive accessibility label for a better screen reader experience.

♿ Accessibility: Any a11y improvements made

  • Added accessibilityLabel to flight cards that provides a full summary of flight details (e.g., "AZ123, ITA Airways, from Rome, 10:30, Landed").
  • Implemented accessibilityActions (togglePin) to allow pinning/unpinning flights without needing to use the swipe gesture.
  • Used importantForAccessibility="no-hide-descendants" on inner views to prevent redundant or confusing announcements of individual text elements.
  • Added localized strings for "Pinned," "Pin flight," "Unpin flight," "from," and "to."

PR created automatically by Jules for task 17306194628253588093 started by @TargetMisser

- Add haptic feedback to flight card swipe gestures using expo-haptics.
- Implement comprehensive accessibility labels for flight cards.
- Add accessibility actions (pin/unpin) for screen reader users.
- Add necessary translations for new accessibility strings.

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 May 1, 2026 0:36am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47bca948aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/i18n/translations.ts
Comment on lines +134 to +135
flightAccessibilityPin: 'Pinna volo', flightAccessibilityUnpin: 'Rimuovi pin',
flightFrom: 'da', flightTo: 'per',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove duplicate translation keys from locale maps

The new flightAccessibilityPin, flightAccessibilityUnpin, flightFrom, and flightTo entries are declared twice in each locale object, which introduces TypeScript duplicate-property errors (TS1117) and can break CI/builds that run tsc --noEmit; at runtime, the later declarations also silently overwrite earlier ones. This was introduced in this commit and should be deduplicated in both it and en maps.

Useful? React with 👍 / 👎.

- Add haptic feedback to flight card swipe gestures using expo-haptics.
- Implement comprehensive accessibility labels for flight cards.
- Add accessibility actions (pin/unpin) for screen reader users.
- Add necessary translations for new accessibility strings.

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant