Skip to content

🧹 [code health] Avoid 'any' type in autoNotifications filters#28

Open
TargetMisser wants to merge 2 commits intomainfrom
code-health-avoid-any-5240825150008386210
Open

🧹 [code health] Avoid 'any' type in autoNotifications filters#28
TargetMisser wants to merge 2 commits intomainfrom
code-health-avoid-any-5240825150008386210

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

🎯 What
Created a new interface FR24Flight to replace the any type used inside array .filter() callbacks for shiftDepartures and shiftArrivals within src/utils/autoNotifications.ts.

💡 Why
Relying on any bypasses TypeScript's type-safety checks, which increases the likelihood of runtime errors. Creating and using FR24Flight provides strong typing for flight scheduling data and aligns with best practices for code health and maintainability.

Verification

  • Validated that all properties accessed via optional chaining inside the filter function (e.g., item.flight?.time?.scheduled?.departure) map correctly to the defined FR24Flight type.
  • Passed npm run typecheck cleanly.
  • Validated no regression via npx jest output.

Result
Improved code safety by providing strict compile-time types for flight data operations.


PR created automatically by Jules for task 5240825150008386210 started by @TargetMisser

Create `FR24Flight` interface in `src/types/flight.ts` to strictly type the flight objects passed into `autoNotifications.ts` array filters.

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 Apr 6, 2026 1:36pm

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…file

Create `FR24Flight` interface in `src/types/flight.ts` to strictly type the flight objects passed into `autoNotifications.ts` array filters. Sync `package-lock.json` with `package.json` to fix CI failure.

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant