🧹 [code health] Avoid 'any' type in autoNotifications filters#28
🧹 [code health] Avoid 'any' type in autoNotifications filters#28TargetMisser wants to merge 2 commits intomainfrom
Conversation
Create `FR24Flight` interface in `src/types/flight.ts` to strictly type the flight objects passed into `autoNotifications.ts` array filters. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…file Create `FR24Flight` interface in `src/types/flight.ts` to strictly type the flight objects passed into `autoNotifications.ts` array filters. Sync `package-lock.json` with `package.json` to fix CI failure. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
🎯 What
Created a new interface
FR24Flightto replace theanytype used inside array.filter()callbacks forshiftDeparturesandshiftArrivalswithinsrc/utils/autoNotifications.ts.💡 Why
Relying on
anybypasses TypeScript's type-safety checks, which increases the likelihood of runtime errors. Creating and usingFR24Flightprovides strong typing for flight scheduling data and aligns with best practices for code health and maintainability.✅ Verification
item.flight?.time?.scheduled?.departure) map correctly to the definedFR24Flighttype.npm run typecheckcleanly.npx jestoutput.✨ Result
Improved code safety by providing strict compile-time types for flight data operations.
PR created automatically by Jules for task 5240825150008386210 started by @TargetMisser