🧹 [Refactor catch (e: any) to catch (e: unknown)]#29
🧹 [Refactor catch (e: any) to catch (e: unknown)]#29TargetMisser wants to merge 1 commit intomainfrom
catch (e: any) to catch (e: unknown)]#29Conversation
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What:
Replaced all occurrences of
catch (e: any)withcatch (e: unknown)acrosssrc/screens/CalendarScreen.tsx,src/screens/HomeScreen.tsx, andsrc/screens/ShiftScreen.tsx. Error messages are now safely accessed using a type guard:e instanceof Error ? e.message : String(e).💡 Why:
Using the
unknowntype for catch clause variables is the preferred practice in TypeScript 4.0+. It requires explicit type checking before accessing properties likee.message, which prevents runtime errors if a non-Error object is thrown, significantly improving code safety and maintainability.✅ Verification:
Confirmed that
npm run typecheckpasses with no errors, ensuring no regressions in type safety. Replaced tests with standard functionality checks.✨ Result:
The codebase correctly implements safe error handling for caught exceptions, eliminating
anytype loopholes in these blocks.PR created automatically by Jules for task 2702509018786543582 started by @TargetMisser