🧹 [code health] Avoid 'any' type in parseFlight#35
🧹 [code health] Avoid 'any' type in parseFlight#35TargetMisser wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
🎯 What: Created a comprehensive
FR24Flightinterface insrc/types/flight.tsto replace theanytype used across the app (inShiftTimeline.tsx,FlightScreen.tsx, andfr24api.ts) for mapping FlightRadar24 flight data.💡 Why: Relying on
anybypasses TypeScript's safety features, making it easy to encounter runtime errors with deeply nested data. Centralizing and mapping the nested payload structure explicitly avoids compilation/runtime issues and greatly improves maintainability.✅ Verification: Verified that
npm run typecheckpasses with no type errors. UpdatedFlightScreen.tsxto handle a possibly undefined value correctly. Also verified unit tests continue to pass vianpx jest --passWithNoTests.✨ Result: Reduced
anyusages significantly. Safer and cleaner flight parsing operations.PR created automatically by Jules for task 14513014595699908460 started by @TargetMisser