Skip to content

🧹 [code health] Avoid 'any' type in parseFlight#35

Open
TargetMisser wants to merge 2 commits intomainfrom
fix-any-type-parseflight-14513014595699908460
Open

🧹 [code health] Avoid 'any' type in parseFlight#35
TargetMisser wants to merge 2 commits intomainfrom
fix-any-type-parseflight-14513014595699908460

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

🎯 What: Created a comprehensive FR24Flight interface in src/types/flight.ts to replace the any type used across the app (in ShiftTimeline.tsx, FlightScreen.tsx, and fr24api.ts) for mapping FlightRadar24 flight data.
💡 Why: Relying on any bypasses TypeScript's safety features, making it easy to encounter runtime errors with deeply nested data. Centralizing and mapping the nested payload structure explicitly avoids compilation/runtime issues and greatly improves maintainability.
Verification: Verified that npm run typecheck passes with no type errors. Updated FlightScreen.tsx to handle a possibly undefined value correctly. Also verified unit tests continue to pass via npx jest --passWithNoTests.
Result: Reduced any usages significantly. Safer and cleaner flight parsing operations.


PR created automatically by Jules for task 14513014595699908460 started by @TargetMisser

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 Apr 6, 2026 1:52pm

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant