⚡ Optimize async notification scheduling with Promise.all#7
⚡ Optimize async notification scheduling with Promise.all#7TargetMisser wants to merge 1 commit intomainfrom
Conversation
Replaced sequential `await` loops with parallel `Promise.all` arrays mapped with `try/catch` and `return await` for robustness in `scheduleShiftNotifications` and `schedulePinnedNotifications`. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What:
Replaced sequential
for...ofloops that awaitedNotifications.scheduleNotificationAsyncwithPromise.all()over an array mapped by an async function. Addedtry/catchblocks inside the mappers to prevent one notification failure from canceling the entire batch.🎯 Why:
Using sequential
awaitfor IO operations like notification scheduling causes unnecessary delays and blocks execution longer than needed. Executing them concurrently significantly reduces the overall execution time.📊 Measured Improvement:
A mock benchmark testing 100 schedules with 5ms latency yielded:
PR created automatically by Jules for task 1050984562018563927 started by @TargetMisser