Fix #431: [bug bounty] readpass_file() silently truncates the passphrase at a carriage return - #433
Open
jialfaro wants to merge 1 commit into
Open
Fix #431: [bug bounty] readpass_file() silently truncates the passphrase at a carriage return#433jialfaro wants to merge 1 commit into
jialfaro wants to merge 1 commit into
Conversation
…passphrase at a carriage return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied fix for readpass_file to match its documented contract: instead of truncating at the first '\r' or '\n', the new implementation strips a single trailing '\n' or '\r\n' at the end of the file and rejects any remaining '\r' or '\n' embedded in the passphrase. Updated libcperciva/util/readpass_file.c accordingly. Also updated tests/08-passphrase-file.sh to use printf to write passphrase files (unchanged test semantics, but normalized to use printf). PR title and body below.
prTitle: Fix readpass_file to reject embedded CRs and LFs and strip only trailing newline/CRLF
prBody:
/claim #431
Closes #431
Summary:
Verification:
Files changed:
This resolves the bug report describing silent truncation at a carriage return inside passphrase files. The fix preserves compatibility for files ending with a single '\n' or the Windows '\r\n' line ending.
Closes #431