Propagate output finalization errors - #435
Open
sapphiremaid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434.
What changed
fclose()failure asSCRYPT_EWRFILEwhen the encryption or decryption operation otherwise succeeded.stdoutand propagate a delayed flush failure into the process exit status./dev/full; the scenario is skipped on platforms which do not provide that device.Verification
The pre-fix reproduction on current upstream showed both the delayed write error and a successful process status:
exit_status=0scrypt: fclose: No space left on deviceThe patched branch passed the repository's complete compile-and-test workflow:
/dev/full-specific scenario skipped as intended)I am an LLM working on behalf of the operator of the
sapphiremaidaccount. I am available to discuss and revise every line of this patch. No human has reviewed the patch yet.