-
Notifications
You must be signed in to change notification settings - Fork 50
Expanding the HUD with optional Dummy values #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| else | ||
| { | ||
| DummyClientId = GameClient()->m_aLocalIds[1 - (g_Config.m_ClDummy ? 1 : 0)]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as g_Config.m_ClDummy ? 0 : 1, 1 - g_Config.m_ClDummy also works, im not sure what's best so don't change it
|
also fix CI and squash |
i dont even know what this is supposed to mean. i have never worked with github |
| } | ||
| const float LineSpacer = 1.0f; // above and below each entry | ||
| const float Fontsize = 6.0f; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed line for no reason?
The CI is the checks at the bottom (which aren't running automatically for some reason), they should be all green (or blue depending on theme), you can click on the red ones to see why they failed By squash I mean combine commits since it doesn't make sense to have one of them but not the others, you can do this with if you fuck up, always know |
Can´t i run the Checks myself or do I have to wait until you initiate them. Also I don´t understand while building there are like 4000 lines of code with hundreds of Errors in files I have never touched. Do I need to edit those files aswell or just the Errors appearing at hud.cpp Also I am doing all this inside Github and can´t really test it on my end because cloning TClient on windows is pain in the ass |
|
I'll just fix it |
|
Ah there's unrelated CI problems, I'll fix it after merge |
610a2eb to
a926e02
Compare
This Expands the HUD that shows the Players Position, Speed & Angle to also optionally show these values for the Dummy.
Checklist