Refactor: Use TVShow.episodes property for episodes trakt id lookup

[glensc]

Requires:

• [python-pytrakt] TVShow: Update seasons to fill episodes in single request moogar0880/PyTrakt#176

[simonc56]

⚠️ this PR breaks TraktLookup functionnality, do not release as is

[glensc]

perhaps explain the problem? steps to reproduce?

[simonc56]

Just sync a show (i tested Attack on Titan) and see that find_by_guid is called for each episode.
With 0.23.3 there is no find_by_guid calls needed for each episode because the lookup table works.

[glensc]

Unable to reproduce, which season/episode is failing?

I added s01e01 test:

• Fix broken TraktLookup invalid match detection for New Agent #1129

just to be sure:

1. you installed required dependencies?
2. you cleared cache so it's not related to cache problem?
3. python version?
4. show your plex inspect of the problematic item

[simonc56]

I found the problem.

The seasons() from trakt/tv.py uses extract_ids() to flatten the ids dict so the te.ids.get(guid.provider) doesn't work anymore, it always return None.

te.ids.get(guid.provider) needs to be replaced by getattr(te, guid.provider), I'll do it

dependencies installed ✔️
cache cleared ✔️
python 3.9.13
occurs on ALL episodes

Can you confirm the bug on your side ?

[glensc]

Found the problem:

• 17abf87 (#1129)

[glensc]

So, perhaps the PR was incomplete:

• https://github.com/moogar0880/PyTrakt/pull/176/files

should add extract_ids to the seasons() method?

but you seem to claim opposite it does extract_ids while I see it doesn't do extract_ids

EDIT: I see the extract_ids now, perhaps 17abf87 should be the fix

[simonc56]

I think we should use extract_ids() everywhere in pytrakt to be consistent with moogar0880 code.

[glensc]

I think we should use extract_ids() everywhere in pytrakt to be consistent with moogar0880 code.

agree, as without that, properties like ids would return None for all providers. extract_ids missing, is bug.