Skip to content

Event stream#12

Merged
shuckc merged 3 commits intomainfrom
event-stream
Jun 26, 2025
Merged

Event stream#12
shuckc merged 3 commits intomainfrom
event-stream

Conversation

@shuckc
Copy link
Copy Markdown
Member

@shuckc shuckc commented Jun 25, 2025

Replace various ad-hoc logging with an event stream that can be async-iterated over to retain the natural ordering between events.

Copilot AI review requested due to automatic review settings June 25, 2025 15:43

This comment was marked as outdated.

@shuckc shuckc requested a review from Copilot June 26, 2025 05:32

This comment was marked as outdated.

@shuckc shuckc requested a review from Copilot June 26, 2025 12:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors logging to use an async event stream for Art-Net events and updates various type names and event dispatch mechanisms. Key changes include:

  • Replacing ad‑hoc logging with an event stream API (async iteration over events) across client, tests, and console.
  • Renaming and updating types (e.g. replacing DGAddr with DatagramAddr) and restructuring event dispatch in the client.
  • Adding new event classes and updating test cases to use async event consumers.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/test_aio_artnet.py Added async event consumer and await functions to validate event stream functionality
aioartnet/models.py Introduced updated type definitions and models for Art-Net nodes, universes, and ports
aioartnet/main.py Simplified main loop by replacing continuous logging with async event iteration
aioartnet/events.py Added new event dataclasses to standardize event notifications
aioartnet/console.py Implemented event printing in the console with task cancellation support
aioartnet/client.py Refactored the client to support event dispatching, consistent type updates and cleanup
aioartnet/init.py Updated module exports to reflect the new event and client APIs
README.md Minor adjustments in log examples to reflect new output formats

Comment thread aioartnet/client.py
Comment thread test/test_aio_artnet.py
@shuckc shuckc merged commit a63a301 into main Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants