Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors logging to use an async event stream for Art-Net events and updates various type names and event dispatch mechanisms. Key changes include:
- Replacing ad‑hoc logging with an event stream API (async iteration over events) across client, tests, and console.
- Renaming and updating types (e.g. replacing DGAddr with DatagramAddr) and restructuring event dispatch in the client.
- Adding new event classes and updating test cases to use async event consumers.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_aio_artnet.py | Added async event consumer and await functions to validate event stream functionality |
| aioartnet/models.py | Introduced updated type definitions and models for Art-Net nodes, universes, and ports |
| aioartnet/main.py | Simplified main loop by replacing continuous logging with async event iteration |
| aioartnet/events.py | Added new event dataclasses to standardize event notifications |
| aioartnet/console.py | Implemented event printing in the console with task cancellation support |
| aioartnet/client.py | Refactored the client to support event dispatching, consistent type updates and cleanup |
| aioartnet/init.py | Updated module exports to reflect the new event and client APIs |
| README.md | Minor adjustments in log examples to reflect new output formats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace various ad-hoc logging with an event stream that can be async-iterated over to retain the natural ordering between events.