Skip to content

fix: Apple 로그인 identityToken 요청 호환 처리 - #127

Merged
issuejong merged 1 commit into
devfrom
fix/126-apple-login-identity-token
Aug 17, 2026
Merged

issuejong merged 1 commit into
devfrom
fix/126-apple-login-identity-token

Conversation

@issuejong

@issuejong issuejong commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

🎋 작업중인 브랜치 및 이슈

🔑 주요 변경사항

  • Apple 로그인 요청의 identityToken을 소셜 로그인 DTO의 token 별칭으로 처리했습니다.
  • 기존 token 필드를 사용하는 요청과의 호환성을 유지했습니다.
  • Swagger의 Apple 로그인 요청 예시를 실제 iOS 요청 형식에 맞게 수정했습니다.
  • identityToken 및 기존 token 요청에 대한 회귀 테스트를 추가했습니다.

Check List

  • Assignees 등록을 하였나요?
  • 라벨(Label) 등록을 하였나요?
  • PR 머지하기 전 반드시 CI가 정상적으로 작동하는지 확인해주세요!

Summary by CodeRabbit

  • Enhancements
    • Apple social login now accepts identityToken in requests.
    • Existing token requests remain supported for backward compatibility.
    • Updated API documentation and examples to reflect both supported fields.
  • Bug Fixes
    • Requests missing both token fields are correctly rejected.

@issuejong issuejong self-assigned this Aug 17, 2026
@issuejong issuejong added the 🐛 fix 버그 수정 label Aug 17, 2026
@issuejong issuejong linked an issue Aug 17, 2026 that may be closed by this pull request
8 tasks
@coderabbitai

coderabbitai Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ab7944dd-6185-490f-b8e9-2fff2f499f55

📥 Commits

Reviewing files that changed from the base of the PR and between e3ae6fe and adf99b7.

📒 Files selected for processing (3)
  • src/main/java/com/moru/server/domain/member/controller/AuthController.java
  • src/main/java/com/moru/server/domain/member/dto/AuthRequestDTO.java
  • src/test/java/com/moru/server/domain/member/controller/AuthControllerTest.java

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Apple social login now accepts identityToken and retains compatibility with token. Swagger documentation reflects the supported fields. Controller tests cover both inputs and missing-token validation.

Changes

Apple login compatibility

Layer / File(s) Summary
Request alias and documentation
src/main/java/com/moru/server/domain/member/dto/AuthRequestDTO.java, src/main/java/com/moru/server/domain/member/controller/AuthController.java
SocialLoginRequest.token accepts identityToken as an alias. Apple login documentation and examples use identityToken while documenting token compatibility.
Controller validation tests
src/test/java/com/moru/server/domain/member/controller/AuthControllerTest.java
Tests cover both token field names, missing-token validation, service delegation, and rejected requests without service interaction.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to adf99

This localized change adds Apple login identityToken compatibility while preserving existing token requests and includes regression coverage; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes Apple login identityToken compatibility and matches the primary changes.
Linked Issues check ✅ Passed The changes satisfy the linked issue by adding identityToken support, preserving token compatibility, updating Swagger, and adding regression and validation tests.
Out of Scope Changes check ✅ Passed All changes directly support Apple login field compatibility, documentation, and related regression coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/126-apple-login-identity-token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@@ -1,5 +1,6 @@
package com.moru.server.domain.member.dto;

import com.fasterxml.jackson.annotation.JsonAlias;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonAlias는 Jackson 역직렬화에만 적용되고 springdoc이 만드는 OpenAPI 스키마엔 반영 안 된다고 합니다. @Schema description에 텍스트로만 적어놨는데, 스키마 필드 목록엔 여전히 token만 나와서 문서만 보고 연동하는 프론트 개발자는 identityToken 지원 여부를 놓칠 수 있다고 하네용.
해결법: 별도 스키마 수정까진 필요 없고, 앱 팀에 별도 공지하거나 PR 설명에 "identityToken도 받음" 명시하면 좋을 것 같습니다!

@issuejong
issuejong merged commit 480058f into dev Aug 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 fix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Apple 로그인 identityToken 요청 호환 처리

2 participants