Resolves an issue that appeared in #1305 with some TPAGB stars in the ECSN range (but not satisfying ECSN conditions) exploding as CCSNe

[ilyamandel]

In #1305, I tried to address a situation where TPAGB stars entered the ResolveSupernova() function but were not, in fact, supposed to explode in a supernova because they did not satisfy the ECSN criteria (most likely because --allow-non-stripped-ECSN was false). Prior to that fix, we allowed these to become white dwarfs, but that created problems such as the impact of a sudden mass change associated with instantaneous envelope removal from the binary (e.g., a Blaauw kick, a non-conservation of a*M, etc.). In that fix, I opted to treat all systems that did not qualify for ECSN as regular core-collapse SNe. However, as @pauldisberg pointed out, this created a different set of problems, such as an abundance of low-kick NSs forming from stars that really should not have experienced CCSNe at all. In this update, I am fixing the treatment properly, by modifying the calculation of whether a star should go supernova to return false in cases when neither the ECSN nor CCSN criteria are satisfied. To achieve this, I added a new parameter (threshold mass, generally expected to be MCH or MECS) to CalculateCoreMassAtSupernova_Static(). I also removed McSN from GBParams, instead computing it on the fly when needed.

Finally, I cleaned up documentation in a couple of places, such as adding output column descriptions directly to Quick Links for easier navigation.

I am also starting to upload some more Matlab post-processing scripts; these do not require review (and are still works in progress).

[jeffriley]

Looks good - approved

[ilyamandel]

Just to prove that all is still well with conservation of a*Mtot for binaries making WDs without tides, GWs, or mass transfer (plot made with latest code version):

[pauldisberg]

Approved: NS kick distributions look good, the peak caused by stars that would have gone ECSN if they were stripped but now undergo CCSNe is reduced.

[ilyamandel]

Thanks, @pauldisberg ! If you happen to have a plot showing the impact of this change (say, the single NS kick distributions before and after the change with default assumptions, i.e., without allowing for ECSNe from non-stripped donors), could you post it here -- useful to have such information handy when we try to remember a year later why we made this change. :-)

[pauldisberg]

As requested: the kick distributions for individual NSs (through ./COMPAS -n 100000 --mode SSE --random-seed 1714388113). The figure shows interpolated histograms with bins of 10 km/s, for varying v_NS and sigma_kick (Mandel & Müller 2020), for the COMPAS version before Ilya's fix (v03.20.02) and the version after Ilya's fix (cf. Fig. 2 of Kapil et al. 2023).