Fix for issue #400

[brcekadam]

Fix for issue #400. I removed the ambiguous ZSOL value, and now we will have ZSOL_HURLEY = 0.02, ZSOL_ANDERS = 0.019, ZSOL_ASPLUND = 0.0142. I checked the prescriptions and made sure that correct Zsol value is used (hopefully I didn't miss any).

[jeffriley]

Thanks @brcekadam. Just one request:

Can you provide functions for ZSOL_ANDERS and ZSOL_ASPLUND that mirror LogMetallicityXi() for ZSOL_HURLEY, and use those? Otherwise we might be taking the log of the same number many thousands of times over the course of the evolution of each system - when we really only need to do it once (log is an expensive function).

You can change the name of the function if you want - it's LogMetallicityXi() because Hurley used 'xi' in his paper (from memory). Or maybe just use LogMetallicityXi_HURLEY() etc. Whatever works.

[brcekadam]

That's a good point, @jeffriley! I've just pushed the changes, and it should be fixed :-)

[ilyamandel]

Looks great, @brcekadam !

Apologies for merging in another PR just before yours (you'll have to merge in dev and increment the version number in order to avoid a changelog conflict).

[brcekadam]

No worries, @ilyamandel! :-) It should be ready now.

I am using the "dismiss review" feature only because Jeff's request was fully addressed and he is travelling at the moment.