Print final velocity components#1407
Merged
Merged
Conversation
Collaborator
Author
|
These output variables are not included by default. To access them without modifying the source code, you should use the logfile-definitions option:
|
ilyamandel
requested changes
Jun 30, 2025
Collaborator
There was a problem hiding this comment.
Thank you, @reinhold-willcox !
But I am not a huge fan of calling it SPEED_X, etc. Elsewhere in the outputs, we always use VELOCITY for 3-d vectors and speed for scalars. Can we retain that for consistency?
Collaborator
Author
|
@ilyamandel Fixed |
ilyamandel
approved these changes
Jun 30, 2025
ilyamandel
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @reinhold-willcox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the components of the velocity vector for a given star to possible output, as requested by @TomWagg