Skip to content

Updated default mandelmuller kickparams#1450

Merged
ilyamandel merged 7 commits into
devfrom
update_defaul_mandelmuller_kickparams
Jan 28, 2026
Merged

Updated default mandelmuller kickparams#1450
ilyamandel merged 7 commits into
devfrom
update_defaul_mandelmuller_kickparams

Conversation

@pauldisberg

Copy link
Copy Markdown
Collaborator

Updated the default Muller Mandel kick parameters values to v_NS = 630 km/s and sigma_kick = 0.45, from Disberg+2026 (previously from Kapil+2023). The sigma_kick value has been changed for both NSs and BHs.

updated mullermandel kick params to Disberg+2026
updated changelog
@github-actions

Copy link
Copy Markdown

✅ COMPAS Build Successful!

Item Value
Commit b7c8bc8
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot


Generated by COMPAS CI

@ilyamandel ilyamandel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pauldisberg ,
This looks good, but as you rightly said, you also need to update the documentation. The documentation is in the same github repo; see ../online-docs/pages/... In this case, I'd also update whats-new.rst to let users know about this change. Since you spotted a mistake in the Hobbs parameter description in the documentation, could you please that, too? Finally, since the default settings have changed, please update the yaml file -- you'll want to run something like
./COMPAS --create-YAML-file ../compas_python_utils/preprocessing/compasConfigDefault.yaml

@github-actions

Copy link
Copy Markdown

✅ COMPAS Build Successful!

Item Value
Commit d63ec5e
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot


Generated by COMPAS CI

@ilyamandel ilyamandel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauldisberg : looks good. I tweaked whatsnew to remove the mention of the Hobbs update in 03.28.00 -- that was actually done in 03.20.06 (even though the documentation was not everywhere correctly updated, the code was), and there's already a record of that in whatsnew.

@ilyamandel
ilyamandel merged commit a24ac2c into dev Jan 28, 2026
3 checks passed
@ilyamandel
ilyamandel deleted the update_defaul_mandelmuller_kickparams branch January 28, 2026 20:41
@github-actions

Copy link
Copy Markdown

✅ COMPAS Build Successful!

Item Value
Commit 9f95573
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot


Generated by COMPAS CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants